update cyw20829 integration #81121

npal-cy · 2024-11-08T08:55:54Z

Boards: cyw20829: add custom flashloaded with 64k of erase block size

Add custom flashloaded (for openocd) with 64k of erase block size. Default one has 512, which cause MCUbootloader overwrite during flash primary application.

soc: cyw20829: add support of Secure LCS

Enable support of SECURE LCS stage. In this stage, the protection
state is set to “secure”. A secured device will boot only when the authentication of its flash boot and application code succeeds.

soc: cyw20829: Initial integrate Cypress MCUBoot for 20829

Added custom mcuboot cmake for sign/encrypt by using cysecuretools.

soc/infineon/cat1b/cyw20829/mcuboot.cmake

npal-cy · 2024-11-11T23:07:46Z

Hi @carlescufi,

Binary file not allowed: boards/infineon/cyw920829m2evk_02/support/CYW208xx_SMIF_64K.FLM
Error: See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.

we added openocd flashloader (boards/infineon/cyw920829m2evk_02) and Compliance Checks fail as binary file not allowed.
Does Binary file rules also applies for openocd flashloader?

Regards,
Nazar

zephyrbot · 2024-12-10T15:21:16Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

sreeramIfx · 2025-05-13T05:09:47Z

@nordicjm Please review

nordicjm · 2025-05-14T06:22:02Z

@nordicjm Please review

You should click the re-request review buttons next to the names in the review list, otherwise this comment could get easily missed like just now when I lost this PR and suddenly remembered then had to search through every PR I've reviewed looking for "cy" to find it

boards/infineon/cyw920829m2evk_02/board.cmake

nordicjm · 2025-05-14T06:23:37Z

soc/infineon/cat1b/cyw20829/Kconfig.soc

+config CYW20829_FLASH_SAHB_ADDR
+	hex
+	default $(dt_nodelabel_reg_addr_hex,flash_sahb)
+
+config CYW20829_FLASH_CBUS_ADDR
+	hex
+	default $(dt_nodelabel_reg_addr_hex,flash_cbus)
+
+config CYW20829_SRAM_SAHB_ADDR
+	hex
+	default $(dt_nodelabel_reg_addr_hex,sram_sahb)
+
+config CYW20829_SRAM_CBUS_ADDR
+	hex
+	default $(dt_nodelabel_reg_addr_hex,sram_cbus)


these need to move to Kconfig file as they have no use in sysbuild (and there is no devicetree even)

not resolved (fix in original commit, no fixup commits)

nordicjm · 2025-05-14T06:24:43Z

soc/infineon/cat1b/cyw20829/CMakeLists.txt

+
+if(CONFIG_INFINEON_SECURE_LCS OR CONFIG_BOOTLOADER_MCUBOOT)
+  # Check cysecuretools
+  find_program(CYSECURETOOLS cysecuretools)


should just use the required flag in find_program() rather then re-inventing the wheel

nordicjm · 2025-05-14T06:25:00Z

soc/infineon/cat1b/cyw20829/CMakeLists.txt

+        ${CONFIG_INFINEON_SECURE_POLICY}
+        ${default_policy_name}


2 space indent not 4 for cmake

nordicjm · 2025-05-14T06:25:18Z

soc/infineon/cat1b/cyw20829/CMakeLists.txt

+    )
+
+  if(NOT default_policy)
+      message(FATAL_ERROR "Can't find policy:${CONFIG_INFINEON_SECURE_POLICY}"


missing space after :

nordicjm · 2025-05-14T06:27:53Z

boards/infineon/cyw920829m2evk_02/doc/index.rst

+The following configuration options can be used to build for a device which has been provisioned
+to SECURE LCS and configured to use an encrypted flash interface:
+
+- ``CONFIG_INFINEON_SECURE_LCS=y``: Enable if the target device is in SECURE LCS


use

:kconfig:option:`CONFIG_blah...`

and just say to set them not with the =blah part, so that they have links to the actual Kconfig descriptions

nordicjm · 2025-05-14T06:29:06Z

boards/infineon/cyw920829m2evk_02/doc/index.rst

+   :west-args: -p always
+   :gen-args: -DCONFIG_BOOTLOADER_MCUBOOT=y -DCONFIG_MCUBOOT_SIGNATURE_KEY_FILE=\"/path/to/cypress/mcuboot/boot/cypress/keys/cypress-test-ec-p256.pem\"
+
+If you use ``CONFIG_MCUBOOT_ENCRYPTION_KEY_FILE`` to generate an encrypted image then the final


sreeramIfx · 2025-05-14T17:51:39Z

@nordicjm Please review

You should click the re-request review buttons next to the names in the review list, otherwise this comment could get easily missed like just now when I lost this PR and suddenly remembered then had to search through every PR I've reviewed looking for "cy" to find it

I am not seeing that button on this PR, Probably because I was not the initial author of this PR?

Add custom flashloader (for openocd) with 64k of erase block size. Default one has 512, which cause MCUbootloader overwrite during flash primary application. Signed-off-by: Sreeram Tatapudi <[email protected]>

Instead of using app_header.c generate the app header using python script and merge with final binary post build Signed-off-by: Sreeram Tatapudi <[email protected]>

Enable support of SECURE LCS stage. In this stage, the protection state is set to “secure”. A secured device will boot only when the authentication of its flash boot and application code succeeds Signed-off-by: Sreeram Tatapudi <[email protected]>

Added custom mcuboot cmake for sign/encrypt by using cysecuretools Signed-off-by: Sreeram Tatapudi <[email protected]> Signed-off-by: Nazar Palamar <[email protected]>

sonarqubecloud · 2025-05-21T18:53:07Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kartben

doc changes look ok - thanks!

zephyrbot added the platform: Infineon Infineon Technologies AG label Nov 8, 2024

zephyrbot requested review from ifyall and talih0 November 8, 2024 08:56

zephyrbot assigned ifyall Nov 8, 2024

npal-cy force-pushed the topic/update_cyw20829_integration branch from b305e9f to 97f4a22 Compare November 8, 2024 10:30

nordicjm reviewed Nov 8, 2024

View reviewed changes

soc/infineon/cat1b/cyw20829/mcuboot.cmake Outdated Show resolved Hide resolved

npal-cy force-pushed the topic/update_cyw20829_integration branch from 97f4a22 to 881bb90 Compare November 11, 2024 22:33

npal-cy force-pushed the topic/update_cyw20829_integration branch 6 times, most recently from 17013c3 to b1bd9df Compare November 13, 2024 14:57

npal-cy force-pushed the topic/update_cyw20829_integration branch 3 times, most recently from 7105457 to 0501d89 Compare November 21, 2024 08:32

npal-cy force-pushed the topic/update_cyw20829_integration branch from 0501d89 to c70347d Compare December 10, 2024 15:20

zephyrbot added manifest manifest-hal_infineon labels Dec 10, 2024

npal-cy force-pushed the topic/update_cyw20829_integration branch from c70347d to 224f48f Compare December 10, 2024 15:38

zephyrbot added the DNM This PR should not be merged (Do Not Merge) label Dec 10, 2024

npal-cy force-pushed the topic/update_cyw20829_integration branch 7 times, most recently from 7f37a95 to 8109c99 Compare December 11, 2024 13:50

github-actions bot removed manifest-hal_infineon DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Apr 17, 2025

sreeramIfx force-pushed the topic/update_cyw20829_integration branch 2 times, most recently from 544d5d5 to 9916b14 Compare April 18, 2025 17:52

sreeramIfx force-pushed the topic/update_cyw20829_integration branch 3 times, most recently from e714793 to ffd79a1 Compare May 13, 2025 04:59

nordicjm reviewed May 14, 2025

View reviewed changes

ifyall requested a review from nordicjm May 14, 2025 20:59

sreeramIfx force-pushed the topic/update_cyw20829_integration branch 3 times, most recently from 16dd263 to 80341d3 Compare May 14, 2025 22:53

boards: cyw20829: add custom flashloader with 64k of erase block size

f1c95cc

Add custom flashloader (for openocd) with 64k of erase block size. Default one has 512, which cause MCUbootloader overwrite during flash primary application. Signed-off-by: Sreeram Tatapudi <[email protected]>

sreeramIfx force-pushed the topic/update_cyw20829_integration branch 4 times, most recently from 825575f to 24b1b1a Compare May 20, 2025 00:15

soc: cyw20829: Use python script to generate app header

2078cef

Instead of using app_header.c generate the app header using python script and merge with final binary post build Signed-off-by: Sreeram Tatapudi <[email protected]>

sreeramIfx force-pushed the topic/update_cyw20829_integration branch from 24b1b1a to 017a2b0 Compare May 20, 2025 23:41

sreeramIfx added 2 commits May 21, 2025 11:23

soc: cyw20829: Initial integrate Cypress MCUBoot for 20829

0204cd2

Added custom mcuboot cmake for sign/encrypt by using cysecuretools Signed-off-by: Sreeram Tatapudi <[email protected]> Signed-off-by: Nazar Palamar <[email protected]>

sreeramIfx force-pushed the topic/update_cyw20829_integration branch from 017a2b0 to 0204cd2 Compare May 21, 2025 18:24

nordicjm approved these changes May 23, 2025

View reviewed changes

kartben approved these changes May 23, 2025

View reviewed changes

ifyall approved these changes May 23, 2025

View reviewed changes

kartben merged commit c4866ec into zephyrproject-rtos:main May 24, 2025
27 checks passed

update cyw20829 integration #81121

update cyw20829 integration #81121

Uh oh!

Conversation

npal-cy commented Nov 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

npal-cy commented Nov 11, 2024

Uh oh!

zephyrbot commented Dec 10, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sreeramIfx commented May 13, 2025

Uh oh!

nordicjm commented May 14, 2025

Uh oh!

Uh oh!

nordicjm May 14, 2025

Choose a reason for hiding this comment

Uh oh!

nordicjm May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nordicjm May 14, 2025

Choose a reason for hiding this comment

Uh oh!

nordicjm May 14, 2025

Choose a reason for hiding this comment

Uh oh!

nordicjm May 14, 2025

Choose a reason for hiding this comment

Uh oh!

nordicjm May 14, 2025

Choose a reason for hiding this comment

Uh oh!

nordicjm May 14, 2025

Choose a reason for hiding this comment

Uh oh!

sreeramIfx commented May 14, 2025

Uh oh!

sonarqubecloud bot commented May 21, 2025

Quality Gate passed

Uh oh!

kartben left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

npal-cy commented Nov 8, 2024 •

edited

Loading

zephyrbot commented Dec 10, 2024 •

edited by github-actions bot

Loading

nordicjm May 19, 2025 •

edited

Loading